Update usage instructions #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think README file should specify that in order to use builtin version of React user has to add a line to config file. After installing the gem I was expecting it to "just work" (as `jquery-rails` does - `//= require jquery`), so another option might be changing `React::Rails::Railtie`.
Member
|
Yea. I mentioned this somewhere (may have been in the React repo), but I thought about making it so that we do exactly what Regardless, this does clear it up. And I see you've signed the CLA already so I'll merge this in. Thanks a lot! |
Contributor
Author
|
Rails is always about convention over configuration, so providing default values with ability to override sound like a good choice. I'll send another PR a bit later. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think README file should specify that in order to use builtin version of React user has to add a line to config file.
After installing the gem I was expecting it to "just work" (as
jquery-railsdoes -//= require jquery), so another option might be changingReact::Rails::Railtie.